Run type checking on multiply_add.py #6833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
commented
Apr 23, 2025
| from aiida.engine import ToContext, WorkChain, calcfunction | ||
| from aiida.orm import AbstractCode, Int | ||
| from aiida.plugins.factories import CalculationFactory | ||
|
|
||
| ArithmeticAddCalculation = CalculationFactory('core.arithmetic.add') |
There was a problem hiding this comment.
mypy has troubles understanding that the CalculationFactory returns a Calcjob subclass in this case. So let's import it directly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6833 +/- ##
==========================================
- Coverage 78.44% 78.44% -0.00%
==========================================
Files 568 568
Lines 43093 43092 -1
==========================================
- Hits 33802 33801 -1
Misses 9291 9291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
typing/workflow
branch
from
a71cdd6 to
d09a436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #682Trivial update to add type-checking on one file.