Bump mypy to 1.16.0 #6858

danielhollas · 2025-05-06T01:47:50Z

This is a nice bump since we can remove a lot of type: ignore comments!

.pre-commit-config.yaml

danielhollas · 2025-05-06T01:50:14Z

src/aiida/cmdline/commands/cmd_profile.py

@@ -122,17 +122,17 @@ def profile_setup():
    """Set up a new profile."""


-@verdi_profile.command('configure-rabbitmq')  # type: ignore[arg-type]
+@verdi_profile.command('configure-rabbitmq')
+@click.pass_context


Not quite sure why, but moving pass_context here fixed the following error:

src/aiida/cmdline/commands/cmd_profile.py:135: error: Argument 1 to "pass_context" has incompatible type "Callable[[Any, Any, Any, Any, KwArg(Any)], Any]"; expected "Callable[[Context, Any, Any, Any, KwArg(Any)], Any]" [arg-type] src/aiida/cmdline/commands/cmd_profile.py:135: note: This is likely because "profile_configure_rabbitmq" has named arguments: "ctx". Consider marking them positional-only

danielhollas · 2025-05-06T01:53:28Z

src/aiida/engine/processes/functions.py

-        except Exception as exception:
-            LOGGER.warning(f'function `{func.__name__}` has a docstring that could not be parsed: {exception}')
-            param_help_string = {}
+        if func.__doc__ is None:


This fixes:

src/aiida/engine/processes/functions.py:377: error: Argument 1 to "parse" has incompatible type "str | None"; expected "str" [arg-type]

Github is very confused, the diff here is actually not that bad, we're just handling the func.__doc__ is None case pre-emptively. (We could also log a warning if a calcfunction is missing a docstring, but that seems overly pedantic)

danielhollas · 2025-05-06T01:54:28Z

src/aiida/engine/processes/functions.py

@@ -435,7 +439,7 @@ def define(cls, spec):
                    def indirect_default(value=default):
                        return to_aiida_type(value)
                else:
-                    indirect_default = default
+                    indirect_default = default  # type: ignore[assignment]


Not super clear how to solve this one, since indirect_default can be basically anything

src/aiida/engine/processes/functions.py:438: error: Incompatible types in assignment (expression has type "Any | tuple[()]", variable has type "Callable[[Any], Any]") [assignment]

danielhollas · 2025-05-06T01:55:18Z

src/aiida/engine/processes/process.py

@@ -80,7 +80,7 @@ class Process(PlumpyProcess):
    class SaveKeys(enum.Enum):
        """Keys used to identify things in the saved instance state bundle."""

-        CALC_ID: str = 'calc_id'
+        CALC_ID = 'calc_id'


src/aiida/engine/processes/process.py:83: error: Enum members must be left unannotated [misc]
src/aiida/engine/processes/process.py:83: note: See https://typing.readthedocs.io/en/latest/spec/enums.html#defining-members

codecov · 2025-05-06T02:05:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (edb8c7e) to head (4db11f8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6858      +/-   ##
==========================================
- Coverage   78.60%   78.59%   -0.00%     
==========================================
  Files         567      567              
  Lines       43096    43099       +3     
==========================================
+ Hits        33870    33871       +1     
- Misses       9226     9228       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

agoscinski · 2025-05-06T06:33:56Z

Note to me: There seems to be also mypy fixes here #6641 Need to check this too. I think we first merge this PR and then rebase the other

agoscinski · 2025-05-06T06:40:45Z

I approve the changes. Just waiting till we release v2.7.0 before merge

danielhollas · 2025-05-08T16:38:29Z

I think we first merge this PR and then rebase the other

Yes, I think merging this first makes sense since clearly mypy got better at inferring some types. I also have three typing PRs in progress, #6833 #6707 and #6704, which I will rebase once this is merged.

danielhollas · 2025-06-03T00:09:47Z

.pre-commit-config.yaml

@@ -78,7 +78,7 @@ repos:
  - id: mypy
    name: mypy
    entry: mypy
-    args: [--config-file=pyproject.toml]
+    args: [--config-file=pyproject.toml, --pretty]


I didn't know about the --pretty option before, but it results in much friendlier error messages!

danielhollas · 2025-06-03T00:11:21Z

src/aiida/cmdline/groups/dynamic.py

@@ -137,7 +137,7 @@ def apply_options(func):
            shared_options.reverse()

            for option in shared_options:
-                func = option(func)
+                func = option(func)  # type: ignore[operator]


I don't understand why this is needed all of a sudden, especially given that we have basically identical code couple lines above that apparently is fine. mypy error:

src/aiida/cmdline/groups/dynamic.py:140: error: "Option" not callable [operator]

danielhollas · 2025-06-03T00:12:54Z

src/aiida/orm/nodes/data/code/legacy.py

@@ -231,7 +231,7 @@ def get_code_helper(cls, label, machinename=None, backend=None):
            return result[0]

    @classmethod
-    def get(cls, pk=None, label=None, machinename=None):
+    def get(cls, pk=None, label=None, machinename=None):  # type: ignore[override]


I don't understand why mypy complains here:

src/aiida/orm/nodes/data/code/legacy.py:234: error: Signature of "get" incompatible with supertype "Entity" [override] def get(cls, pk=None, label=None, machinename=None): ^ src/aiida/orm/nodes/data/code/legacy.py:234: note: Superclass: src/aiida/orm/nodes/data/code/legacy.py:234: note: @classmethod src/aiida/orm/nodes/data/code/legacy.py:234: note: def get(cls, **kwargs: Any) -> Any src/aiida/orm/nodes/data/code/legacy.py:234: note: Subclass: src/aiida/orm/nodes/data/code/legacy.py:234: note: @classmethod src/aiida/orm/nodes/data/code/legacy.py:234: note: def get(cls, pk: Any = ..., label: Any = ..., machinename: Any = ...) -> Any

danielhollas · 2025-06-03T00:15:24Z

src/aiida/tools/archive/imports.py

@@ -924,7 +924,7 @@ def _import_links(
                    raise ImportUniquenessError(
                        f'Node {in_id} already has an outgoing {link_type.value!r} link with label {link_label!r}'
                    )
-                if 'out_id' in link_uniqueness and out_id in existing_out_id_label:
+                if 'out_id' in link_uniqueness and out_id in existing_out_id:


This was a genuine bug! Please see the surrounding code to understand the fix.

Also note how the --pretty mypy output is helpful here!

src/aiida/tools/archive/imports.py:927: error: Non-overlapping container check (element type: "int", container item type: "tuple[Any, Any]") [comparison-overlap] ... if 'out_id' in link_uniqueness and out_id in existing_ou... ^~~~~~~~~~~~~~~~~~~~~...

danielhollas requested review from unkcpz and agoscinski as code owners May 6, 2025 01:47

danielhollas commented May 6, 2025

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

danielhollas commented May 6, 2025

View reviewed changes

agoscinski added this to aiida-core v2.7.1 May 6, 2025

agoscinski moved this to In review in aiida-core v2.7.1 May 6, 2025

danielhollas force-pushed the update-mypy branch from 6404b5b to f557493 Compare May 8, 2025 16:39

agoscinski added the topic/devops label May 21, 2025

danielhollas added the topic/typing label May 25, 2025

Bump mypy to 1.16.0

732dd0f

danielhollas force-pushed the update-mypy branch from f557493 to 732dd0f Compare June 2, 2025 23:24

danielhollas added 5 commits June 3, 2025 00:29

mypy: use --pretty for nicer error messages!

4fa1763

More type:ignore removals!

6849dec

Fix bug in existing archive import validation!

8e2fb40

add new type:ignores

afa0a31

One more strange type:ignore

51323e5

danielhollas changed the title ~~Bump mypy to 1.15.0~~ Bump mypy to 1.16.0 Jun 3, 2025

Remove extra annotations

4db11f8

danielhollas commented Jun 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump mypy to 1.16.0 #6858

Bump mypy to 1.16.0 #6858

Uh oh!

danielhollas commented May 6, 2025

Uh oh!

Uh oh!

danielhollas May 6, 2025

Uh oh!

danielhollas May 6, 2025

Uh oh!

danielhollas May 6, 2025

Uh oh!

danielhollas May 6, 2025

Uh oh!

codecov bot commented May 6, 2025 •

edited

Loading

Uh oh!

agoscinski commented May 6, 2025 •

edited

Loading

Uh oh!

agoscinski commented May 6, 2025

Uh oh!

danielhollas commented May 8, 2025

Uh oh!

danielhollas Jun 3, 2025

Uh oh!

danielhollas Jun 3, 2025

Uh oh!

danielhollas Jun 3, 2025

Uh oh!

danielhollas Jun 3, 2025

Uh oh!

Uh oh!

Bump mypy to 1.16.0 #6858

Are you sure you want to change the base?

Bump mypy to 1.16.0 #6858

Uh oh!

Conversation

danielhollas commented May 6, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

agoscinski commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agoscinski commented May 6, 2025

Uh oh!

danielhollas commented May 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented May 6, 2025 •

edited

Loading

agoscinski commented May 6, 2025 •

edited

Loading