Expose ShowkaseBrowserComponent (and color and typography) in PaparazziShowkaseTestPreview #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinaygaba
reviewed
Apr 21, 2023
...nb/android/showkase/screenshot/testing/paparazzi/sample/MyPaparazziShowkaseScreenshotTest.kt
Outdated
Show resolved
Hide resolved
vinaygaba
reviewed
May 9, 2023
...nb/android/showkase/screenshot/testing/paparazzi/sample/MyPaparazziShowkaseScreenshotTest.kt
Outdated
Show resolved
Hide resolved
vinaygaba
reviewed
May 9, 2023
.../com/airbnb/android/showkase/screenshot/testing/paparazzi/PaparazziShowkaseScreenshotTest.kt
Show resolved
Hide resolved
andersu
changed the title
|
@vinaygaba I can't see any details of why the ui-testing workflows fail. Are there any commands I can run locally to try to figure it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding on #294 by @vinaygaba I wanted more control of when the screenshot should actually be taken.
My use case is that I want some screenshots to be taken for every locale that we support in our app. In these kind of previews we typically use localised string resources.
For other screenshots we just use dummy texts in English and only want one screenshot taken.
I have added one localised button preview where the text is "Button" in English and "Knapp" in Norwegian and I use my new callback in the sample module.
Let me know if you can think of other better ways to achieve what I want.
I notice that a lot of screenshots changed when I ran
./gradlew :showkase-screenshot-testing-paparazzi-sample:recordPaparazziDebugLet me know if you think I messed something up.