[utils] KeyframeSelection: Exit if there is not output extension for videos #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…videos For input videos, frames are not already available on disk, meaning the output SfMData files cannot be written unless the selected frames are also written on disk. By default, the `outputExtension` parameter is set to `none`, meaning that the selected frames are not going to be written on disk. Prior to this commit, the video would be fully processed, and an error would only be raised at the very end of the process, when attempting to write the SfMData files. With it, the check is performed beforehand, and the program immediately exits before starting to process the video if the output extension is set to `none`.
cbentejac
requested review from
Alxiice,
CedricThebault,
fabiencastan and
servantftransperfect
Alxiice
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For input videos, frames are not already available on disk, meaning the output SfMData files cannot be written unless the selected frames are also written on disk. By default, the
outputExtensionparameter is set tonone, meaning that the selected frames are not going to be written on disk.Prior to this pull request, the video would be fully processed, and an error would only be raised at the very end of the process, when attempting to write the SfMData files. With it, the check is performed beforehand, and the program immediately exits before starting to process the video if the output extension is set to
none.