Skip to content

[utils] KeyframeSelection: Exit if there is not output extension for videos #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbentejac wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −0
Open

[utils] KeyframeSelection: Exit if there is not output extension for videos #2043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/software/utils/main_keyframeSelection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,22 @@ int aliceVision_main(int argc, char** argv)
return EXIT_FAILURE;
}

if (outputExtension == "none")
{
for (std::size_t i = 0; i < nbCameras; i++)
{
const std::string ext = fs::path(inputPaths.at(i)).extension().string();
if (image::isVideoExtension(ext))
{
ALICEVISION_LOG_ERROR("At least one input path (" << inputPaths.at(i) << ") is a video. "
<< "The output extension being set to '" << outputExtension
<< "', the selected keyframes will not be written on disk, meaning the SfMData "
<< "file for the keyframes cannot be written. An output extension is needed for video inputs.");
return EXIT_FAILURE;
}
}
}

brands.resize(nbCameras);
models.resize(nbCameras);
mmFocals.resize(nbCameras);
Expand Down