Upgrade landmark code for swig compatibility #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftransperfect
force-pushed
the
fix/landmarkSwig
branch
from
aa7f7be to
af17064
Compare
CedricThebault
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Landmarkclass to improve its compatibility and encapsulation when used with SWIG (Simplified Wrapper and Interface Generator) for language bindings. The main changes ensure that internal data members are properly hidden from SWIG while still providing controlled access via properties.SWIG compatibility and encapsulation improvements:
getX()andgetRgb()in#ifndef SWIGguards inLandmark.hppto prevent SWIG from exposing direct references to internal members. [1] [2]%ignore aliceVision::sfmData::Landmark::_X;inLandmark.ito explicitly hide the_Xmember from SWIG-generated bindings.SWIG interface enhancements:
XusinggetXandsetXto allow controlled access to the landmark's 3D position in language bindings, without exposing the internal member directly.