Skip to content

Upgrade landmark code for swig compatibility #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CedricThebault merged 1 commit into from
Jan 15, 2026
Merged

Upgrade landmark code for swig compatibility #2049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aliceVision/sfmData/Landmark.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ class Landmark
* @brief Get the 3D position of the landmark (non-const version)
* @return Reference to the 3D position vector
*/
#ifndef SWIG
Vec3& getX() { return _X; }
#endif

/**
* @brief Set the 3D position of the landmark
Expand Down Expand Up @@ -161,7 +163,9 @@ class Landmark
* @brief Get the RGB color of the landmark (non-const version)
* @return Reference to the RGB color associated with the landmark
*/
#ifndef SWIG
image::RGBColor& getRgb() { return _rgb; }
#endif

/**
* @brief Set the RGB color of the landmark
Expand Down
2 changes: 2 additions & 0 deletions src/aliceVision/sfmData/Landmark.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
%ignore aliceVision::sfmData::Landmark::_observations;
%ignore aliceVision::sfmData::Landmark::_parallaxRobust;
%ignore aliceVision::sfmData::Landmark::_isPrecise;
%ignore aliceVision::sfmData::Landmark::_X;

//Add new swig only C++ code
%extend aliceVision::sfmData::Landmark {
Expand Down Expand Up @@ -51,6 +52,7 @@
rgb = property(getRgbVec3, setRgbVec3)
state = property(getState, setState)
descType = property(getDescType, setDescType)
X = property(getX, setX)
%}
}

Expand Down
Loading