Skip to content

Update the name of the wandb callback #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabrieltseng merged 2 commits into from
Dec 16, 2025
Merged

Update the name of the wandb callback #265

gabrieltseng merged 2 commits into from
Dec 16, 2025

Conversation

@gabrieltseng
Copy link
Contributor

@gabrieltseng gabrieltseng commented Dec 11, 2025

Currently, it clashes with the same class in rslearn leading to the following error:

- Multiple subclasses with name SaveWandbRunIdCallback. Give the full class path to avoid ambiguity: rslearn.lightning_cli.SaveWandbRunIdCallback, rslp.lightning_cli.SaveWandbRunIdCallback.

@gabrieltseng gabrieltseng requested a review from favyen2 December 11, 2025 15:05
@favyen2
Copy link
Collaborator

favyen2 commented Dec 11, 2025

I'll update the code to use new WindowStorage API.

@favyen2
Copy link
Collaborator

favyen2 commented Dec 15, 2025

This PR should fix the problems: #266

@gabrieltseng gabrieltseng merged commit 030c153 into master Dec 16, 2025
6 of 8 checks passed
@gabrieltseng gabrieltseng deleted the gabi/wandb_bugfix branch December 16, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@favyen2 favyen2 favyen2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabrieltseng @favyen2