-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-style execution for Python-defined experiments #600
Conversation
Add ability to display the executor output. Can be used as follows: ```python output = executor.execute_step_graph(step_graph) output.display() ```
Seems like the lint and type check failed, but for reasons independent of this PR. Shall I resolve those anyway? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apoorvkh Thank you for the PR! The changes look good to me.
Some of the CI tests don't run due to permissions errors, but I ran some of them locally.
That's great -- thanks a lot @AkshitaB! |
Hey!
I think the Tango CLI is really nice and would really like if we could support Python-defined experiments with CLI-style execution. So I modularized the CLI run functions and decoupled them from
__main__.py
.Now we can also run scripts like:
This should be the same as
tango run examples/euler/euler.jsonnet
!If we want to use the default
TangoGlobalSettings
, we can also shorten the block toThis includes the changes from (@BigRedT) Tanmay's PR #491. CLI functionality should be completely the same. I ran the tests in
tests/main_test.py
successfully. Formatted withisort
andblack
and checked withruff
andmypy
. Docs needed.What do you think? Happy to make adjustments as you see fit!