Skip to content

Upgrade to php 84 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

Conversation

krchiper
Copy link
Contributor

@krchiper krchiper commented Mar 25, 2025

This PR is based on PR #114 (Fix ci pipeline) and therefore includes the same fixes as that

Psalm drives alot of conflicting packages into this one, so the conflict section in composer.json is growing

Code coverage hint for ExceptionDetailsTraitTest has been removed as I can't get it to work with both php 8.1 -> 8.4

// #[CoversTrait(ExceptionDetailsTrait::class)]  <--- needed by phpunit 12
// #[CoversClass(ExceptionDetailsTrait::class)]  <--- needed by phpunit 10 + 11
final class ExceptionDetailsTraitTest extends TestCase

Psalm upgraded to latest version and fixes applied to code base

@krchiper
Copy link
Contributor Author

Can you approve checks?

Copy link
Contributor

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @krchiper !
Thank you for your contribution. I have a couple of things to fix before releasing it. Hopefully, it won't take long.

@delatrie delatrie merged commit 89404e9 into allure-framework:main Apr 9, 2025
25 checks passed
@krchiper krchiper deleted the upgrade-to-php-84 branch April 9, 2025 13:45
@krchiper krchiper restored the upgrade-to-php-84 branch April 10, 2025 07:58
@glo71317
Copy link

@delatrie Thank you for adding the support! When can we expect the stable version to be released?

@delatrie
Copy link
Contributor

@glo71317 It has just been released as 3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants