Skip to content

feat: Add created_at to Journal model #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtatarkin
Copy link
Contributor

Server returns the created_at but it is ignored by SDK, this pull request addresses this issue as created_at could be really helpful. E.g.

    {
        "id": "e364bdba-2b74-4dda-a9a0-ecbf38eedbcf",
        "entry_type": "JNLC",
        "from_account": "b91aa6b4-1805-321a-92ca-57434b652430",
        "to_account": "384ee6d9-54e1-4383-8fab-eeeb72777df8",
        "symbol": "",
        "qty": null,
        "price": "0",
        "status": "executed",
        "settle_date": "2025-03-24",
        "system_date": "2025-03-24",
        "net_amount": "10",
        "description": "Invitation reward payout",
        "currency": "USD",
        "created_at": "2025-03-22T13:41:36.468961Z"
    }```

@dtatarkin dtatarkin requested a review from hiohiohio as a code owner April 17, 2025 18:52
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall LGTM! Left a small comment.

@@ -58,6 +58,7 @@ class Journal(ModelWithID):
transmitter_financial_institution: Optional[str] = None
transmitter_timestamp: Optional[str] = None
currency: Optional[SupportedCurrencies] = None
created_at: Optional[datetime] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you please add created_at json field [1] into the test cases [2]?

*1 something below

"created_at": "2024-05-30T09:13:03.642208Z"

*2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants