Skip to content

feat: Add created_at to Journal model #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add created_at to Journal model #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion alpaca/broker/models/journals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from datetime import date
from datetime import date, datetime
from typing import Optional
from uuid import UUID

Expand Down Expand Up @@ -58,6 +58,7 @@ class Journal(ModelWithID):
transmitter_financial_institution: Optional[str] = None
transmitter_timestamp: Optional[str] = None
currency: Optional[SupportedCurrencies] = None
created_at: Optional[datetime] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you please add created_at json field [1] into the test cases [2]?

*1 something below

"created_at": "2024-05-30T09:13:03.642208Z"

*2

alpaca-py/tests/broker/broker_client/test_journal_routes.py

Line 41 in cf798a0

"currency": "USD"



class BatchJournalResponse(Journal):
Expand Down