Skip to content

Add documentation for how embedding works #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pezholio
Copy link
Contributor

Trello card: https://trello.com/c/JfbTFW0e/917-tech-documentation

This adds some information about the flow of embeds, as well as how changes are propogated. There was a bit of duplication in the preview section, so I’ve updated it to link to this new section.

Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fly-by review.
Thanks for documenting this! ⭐

@pezholio pezholio force-pushed the content-modelling/917-add-docs-for-content-modelling-flow branch from ad6100b to 8f52c7d Compare March 11, 2025 14:24
This adds some information about the flow of embeds, as well as how
changes are propogated. There was a bit of duplication in the preview
section, so I’ve updated it to link to this new section.
@pezholio pezholio force-pushed the content-modelling/917-add-docs-for-content-modelling-flow branch from 8f52c7d to 0a394ef Compare March 11, 2025 14:28
Content Block Embedding is mainly handled in the [Publishing API](https://github.com/alphagov/publishing-api/), with some shared code in the
[Content Block Tools gem](https://github.com/alphagov/govuk_content_block_tools) detailed in the diagram and steps below:

<pre lang="mermaid">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I be able to see this as a diagram on the frontend? or is it something I need to plug in elsewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(cool idea if we can get to see the diagram - I've only ever made fiddly sequence diagrams by hand so this would be great!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it should work. I added the extra JS needed in #5019

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a screenshot:

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, it wasn't showing when I ran through docker locally - is it possible to add a yarn install step to the local docker config? It looks like it can be added in the Makefile for a project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, I'll sort that 👍

@pezholio pezholio merged commit ae3baad into main Mar 12, 2025
5 checks passed
@pezholio pezholio deleted the content-modelling/917-add-docs-for-content-modelling-flow branch March 12, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants