Skip to content

Conversation

@tony-p
Copy link

@tony-p tony-p commented Nov 20, 2025

Fixes bug that ament clang tools don't work on windows

Credit to @traversaro for pointing to the proposed fix

… and move to common implementation in ament_lint

Signed-off-by: Tony Paulussen <[email protected]>
@tony-p tony-p force-pushed the fix/ament-clang-tools-windows-support branch from f7ccc78 to 5568e8f Compare November 20, 2025 13:26
@tony-p tony-p requested a review from ahcorde November 20, 2025 21:29
@tony-p
Copy link
Author

tony-p commented Nov 20, 2025

A general question, what is the best way of dealing with linting (flake/pep257) errors. If I run the tests locally, it throws up 100s of errors (more than what jenkins shows) is that because they are the only regressions? What is the best way to go about fixing them? If I run black or isort for simple fixes it changes way more than what I have touched which also doesn't seem ideal.

TLDR; is there a simple way of processing these style errors?

@ahcorde
Copy link
Contributor

ahcorde commented Nov 24, 2025

Pulls: #563
Gist: https://gist.githubusercontent.com/ahcorde/d4bf250d2d0f2565746a0eaa3a037793/raw/46291b259a37cb6d5fff9db63331ef97cb867186/ros2.repos
BUILD args: --packages-above-and-dependencies ament_clang_format
TEST args: --packages-above ament_clang_format
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17588

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@tony-p
Copy link
Author

tony-p commented Nov 24, 2025

@ahcorde I see the windows test is failing due to not being able to find clang format (https://ci.ros2.org/job/ci_windows/26030/consoleFull), are the clang tools installed on the windows runners? I see they are not in the pixi environment for windows development https://raw.githubusercontent.com/ros2/ros2/refs/heads/rolling/pixi.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants