-
Notifications
You must be signed in to change notification settings - Fork 122
Fix/ament clang tools windows support #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Fix/ament clang tools windows support #563
Conversation
… and move to common implementation in ament_lint Signed-off-by: Tony Paulussen <[email protected]>
…ang* execution Signed-off-by: Tony Paulussen <[email protected]>
f7ccc78 to
5568e8f
Compare
Signed-off-by: Tony Paulussen <[email protected]>
Signed-off-by: Tony Paulussen <[email protected]>
Signed-off-by: Tony Paulussen <[email protected]>
|
A general question, what is the best way of dealing with linting (flake/pep257) errors. If I run the tests locally, it throws up 100s of errors (more than what jenkins shows) is that because they are the only regressions? What is the best way to go about fixing them? If I run black or isort for simple fixes it changes way more than what I have touched which also doesn't seem ideal. TLDR; is there a simple way of processing these style errors? |
|
Pulls: #563 |
|
@ahcorde I see the windows test is failing due to not being able to find clang format (https://ci.ros2.org/job/ci_windows/26030/consoleFull), are the clang tools installed on the windows runners? I see they are not in the pixi environment for windows development https://raw.githubusercontent.com/ros2/ros2/refs/heads/rolling/pixi.toml |
Fixes bug that ament clang tools don't work on windows
Makes a small step to make common utils according to discussion
Credit to @traversaro for pointing to the proposed fix