route53_zone - Remove default value of false
for dnssec
parameter
#2553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I suggest removing the default value for
dnssec
parameter inroute53_zone
module.The current implementation results in a "catch-22": enabling DNSSEC for Route53 zone requires a key-signing key to be created (e.g., via
route53_key_signing_key
module), while creating a key-signing key requires a zone to exist.Consider the following tasks:
On the first execution, these three tasks produce the expected result: create a zone, create a KSK, and then enable DNSSEC for that zone.
However, the subsequent executions of the same tasks will first disable DNSSEC (task 1) and then re-enable it (task 3), which is not idempotent and, more importantly, will likely result in DNS resolution disruption.
Removing the default value addresses this behavior.
ISSUE TYPE
COMPONENT NAME
route53_zone