Skip to content

route53_zone - Remove default value of false for dnssec parameter #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

route53_zone - Remove default value of false for dnssec parameter #2553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf0095
Remove default value of `false` for `dnssec` parameter
ichekaldin Mar 18, 2025
f016aef
Add changelog fragment
ichekaldin Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/2553-route53_zone-remove-dnssec-default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- route53_zone - Remove the default value for ``dnssec`` parameter to avoid idempotency issues (https://github.com/ansible-collections/amazon.aws/pull/2553).
6 changes: 4 additions & 2 deletions plugins/modules/route53_zone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
description:
- Enables DNSSEC signing in a specific hosted zone.
type: bool
default: false
version_added: 9.2.0
extends_documentation_fragment:
- amazon.aws.common.modules
Expand Down Expand Up @@ -352,6 +351,9 @@ def ensure_dnssec(zone_id: str) -> bool:
changed = False
dnssec = module.params.get("dnssec")

if dnssec is None:
return changed

response = get_dnssec(zone_id)
dnssec_status = response["Status"]["ServeSignature"]

Expand Down Expand Up @@ -661,7 +663,7 @@ def main():
delegation_set_id=dict(),
tags=dict(type="dict", aliases=["resource_tags"]),
purge_tags=dict(type="bool", default=True),
dnssec=dict(type="bool", default=False),
dnssec=dict(type="bool"),
)

mutually_exclusive = [
Expand Down