Feature filter remove_keys #8443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vbotka this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
felixfontein
added
check-before-release
vbotka
force-pushed
the
feature-filter-remove_keys
branch
from
6d5e4c1 to
304e355
Compare
ansibullbot
added
integration
This was referenced Jun 1, 2024
felixfontein
reviewed
Jun 1, 2024
|
The test |
ansibullbot
added
ci_verified
Closed
1 task
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
removed
the
needs_revision
vbotka
force-pushed
the
feature-filter-remove_keys
branch
from
1fff6c1 to
a094263
Compare
|
IMO, this PR is ready too. Would it be possible to review it? The below diff shows the changes are trivial shell> diff keep_keys.py remove_keys.py |
felixfontein
reviewed
Jun 6, 2024
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
|
Done. Thank you! |
felixfontein
approved these changes
Jun 6, 2024
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8473 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Add filter remove_keys. * Add filter remove_keys integration test, fragment, and maintainer. * Update with plugins/plugin_utils/keys_filter.py * Update according PR #8456 * Update maintainers. * Fix typo in return doc. * Remove local keys_filter.py. Then rebase. * Add local keys_filter.py * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 06f13e7)
|
@vbotka thanks for your contribution! |
|
Thank you! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 7, 2024
) Feature filter remove_keys (#8443) * Add filter remove_keys. * Add filter remove_keys integration test, fragment, and maintainer. * Update with plugins/plugin_utils/keys_filter.py * Update according PR #8456 * Update maintainers. * Fix typo in return doc. * Remove local keys_filter.py. Then rebase. * Add local keys_filter.py * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 06f13e7) Co-authored-by: Vladimir Botka <[email protected]>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
* Add filter remove_keys. * Add filter remove_keys integration test, fragment, and maintainer. * Update with plugins/plugin_utils/keys_filter.py * Update according PR ansible-collections#8456 * Update maintainers. * Fix typo in return doc. * Remove local keys_filter.py. Then rebase. * Add local keys_filter.py * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
austinlucaslake
pushed a commit
to austinlucaslake/community.general
that referenced
this pull request
Mar 14, 2025
* Add filter remove_keys. * Add filter remove_keys integration test, fragment, and maintainer. * Update with plugins/plugin_utils/keys_filter.py * Update according PR ansible-collections#8456 * Update maintainers. * Fix typo in return doc. * Remove local keys_filter.py. Then rebase. * Add local keys_filter.py * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ansible.utils.remove_keys does not work properly. Fixing is not efficient.
Feature request #8442
ISSUE TYPE
COMPONENT NAME
community.general.remove_keys
ADDITIONAL INFORMATION
See: community.general.keep_keys #8438 #8456