Skip to content

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Jan 10, 2025

This is a required change for upgrading Sphinx to version 7+ (see: readthedocs/sphinx_rtd_theme#1465).
It won't work with older versions.

@shahar1 shahar1 marked this pull request as ready for review January 10, 2025 22:53
@shahar1 shahar1 changed the title Update link rel styles tag [BREAKING CHANGE] Update link rel styles tag Jan 11, 2025
@shahar1 shahar1 changed the title [BREAKING CHANGE] Update link rel styles tag [BREAKING CHANGE] Update link tag for compatibility with Sphinx v7 Jan 11, 2025
@potiuk potiuk merged commit de0818f into main Jan 12, 2025
1 check passed
@potiuk
Copy link
Member

potiuk commented Jan 12, 2025

Ah... Did I merge too fast :) ?

@potiuk
Copy link
Member

potiuk commented Jan 12, 2025

Now - we need to do everything to merge the sphinx 7 changes before we build docs ;)

@potiuk
Copy link
Member

potiuk commented Jan 12, 2025

Ah no... I see we should publish new theme for that . Let me do it

potiuk pushed a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants