Integrate alembic check in ci
#49002
Open
+61
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
5513306 to
9a67d8b
Compare
|
Could you add a change to a model in a second commit on this PR (that we will shortly revert/undo) to test that this fails as expected please? |
|
Sure! I would do it later after this CI finished (make sure it could pass now) |
ashb
reviewed
Apr 9, 2025
Comment on lines
1409
to
1415
| ActionCommand( | ||
| name="check-models", | ||
| help="Check if there are model changes without a corresponding migration", | ||
| description="Check if the current models require new migrations to be generated", | ||
| func=lazy_load_command("airflow.cli.commands.db_command.check_models"), | ||
| args=(ARG_VERBOSE,), | ||
| ), |
There was a problem hiding this comment.
Oh, I'm not sure we want this in here though actually.
The airflow db is designed for end users/Airflow administrators to run, but the check command is only useful for Airflow devs
There was a problem hiding this comment.
Thanks for reviewing, I would remove it from airflow db ~
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
9a67d8b to
f389818
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
f389818 to
b13a09c
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
2 times, most recently
from
b3e4358 to
31fa445
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
14 times, most recently
from
cc8b840 to
f09bb95
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
4 times, most recently
from
9f22ec4 to
b68002a
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
b68002a to
e4ec1a5
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
e4ec1a5 to
4935d6e
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
4935d6e to
2604527
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
2604527 to
3dee702
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
5 times, most recently
from
6def718 to
8fe2c39
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
2 times, most recently
from
66cd694 to
4c3b055
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
4c3b055 to
9645890
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
3 times, most recently
from
2cc7087 to
ae67e5a
Compare
guan404ming
changed the title
alembic checkalembic check in ci
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
ae67e5a to
5e68e28
Compare
guan404ming
force-pushed
the
integrate-alembic-check-in-ci
branch
from
5e68e28 to
9354811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
closes #48998
cc: @ashb
Why
Since Alembic 1.9, a built-in command
alembic checkis available to detect database model changes that don't have corresponding migration files. This feature is crucial for maintaining database integrity by ensuring developers create appropriate migration files whenever they modify database models.Currently, our CI pipeline runs various migration tests, but it doesn't verify if model changes have corresponding migrations. Integrating this check into our CI ensures that no model changes go unnoticed, preventing potential issues that could arise when applying migrations in production.
How
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.