Add packages-metadata generation functions to S3 Docs publishing #50059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
potiuk,
ashb,
jedcunningham and
amoghrajesh
as code owners
|
We are nearly there :) one last step, planning to try some end to end runs in next two days. |
gopidesupavan
commented
Apr 30, 2025
|
Nice! Getting closer to a |
potiuk
approved these changes
Apr 30, 2025
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
May 1, 2025
…che#50059) * Add packages-metadata generation functions to S3 Docs publishing * Add semver package
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 1, 2025
With apache#50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same `.venv` environment and when someone wants to run `breeze` tests using that `.venv`, it is great if `uv sync` installs all that is needed to run breeze tests as well. The apache#50059 added `awswrangler` that was not part of any other project and even after `uv sync` in the main repo, `breeze` tests could not be run.
potiuk
added a commit
that referenced
this pull request
May 1, 2025
With #50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same `.venv` environment and when someone wants to run `breeze` tests using that `.venv`, it is great if `uv sync` installs all that is needed to run breeze tests as well. The #50059 added `awswrangler` that was not part of any other project and even after `uv sync` in the main repo, `breeze` tests could not be run.
github-actions bot
pushed a commit
that referenced
this pull request
May 1, 2025
…oject (#50078) With #50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same `.venv` environment and when someone wants to run `breeze` tests using that `.venv`, it is great if `uv sync` installs all that is needed to run breeze tests as well. The #50059 added `awswrangler` that was not part of any other project and even after `uv sync` in the main repo, `breeze` tests could not be run. (cherry picked from commit e6d6cc1) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
added a commit
that referenced
this pull request
May 1, 2025
…oject (#50078) (#50080) With #50059 it turned out that we need to add breeze also as part of the workspace. With the current ".idea" setup - all our projects share the same `.venv` environment and when someone wants to run `breeze` tests using that `.venv`, it is great if `uv sync` installs all that is needed to run breeze tests as well. The #50059 added `awswrangler` that was not part of any other project and even after `uv sync` in the main repo, `breeze` tests could not be run. (cherry picked from commit e6d6cc1) Co-authored-by: Jarek Potiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/apache/airflow-site/blob/gh-pages/_gen/packages-metadata.json
We would need the
packages-metadata.jsonfile to work properly dropdowns in docs. Now that we are going to publishing all the docs to s3, so its best to generate part of doc publishingpackages-metadataand we can pull this json directly in https://github.com/apache/airflow-site/blob/main/dump-docs-packages-metadata.py here.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.