Skip to content

Update rand requirement from 0.8 to 0.9 (try 2) #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 5 commits into from
Mar 25, 2025
Merged

Update rand requirement from 0.8 to 0.9 (try 2) #7126

alamb merged 5 commits into from
Mar 25, 2025

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 12, 2025 •
edited
Loading

Which issue does this PR close?

@mbrobbel did almost all of this work

Rationale for this change

It turns out rand is part of the arrow public API -- see #7083 (comment)

What changes are included in this PR?

Reapply the changes in #7045

Are there any user-facing changes?

@alamb alamb added the next-major-release the PR has API changes and it waiting on the next major version label Feb 12, 2025
@alamb alamb changed the title Alamb/update rand take2 Update rand requirement from 0.8 to 0.9 (try 2) Feb 12, 2025
@alamb alamb marked this pull request as draft February 12, 2025 13:37
@alamb alamb mentioned this pull request Feb 12, 2025
Merged
@alamb alamb force-pushed the alamb/update_rand_take2 branch from a8401d3 to 4b12e9c Compare February 12, 2025 14:38
@github-actions github-actions bot added parquet Changes to the parquet crate arrow Changes to the arrow crate object-store labels Feb 12, 2025
@alamb alamb marked this pull request as ready for review February 12, 2025 14:43
@alamb alamb mentioned this pull request Mar 14, 2025
Closed
@comphead comphead mentioned this pull request Mar 14, 2025
Closed
@alamb
Copy link
Contributor Author

alamb commented Mar 20, 2025

Thank you for this PR. We are in the process of moving the object_store code to its own repository. Would it be possible for you to create a PR in that repository instead?

(we will handle moving all existing issues to the new repository)

@alamb alamb mentioned this pull request Mar 21, 2025
Closed
@alamb alamb requested a review from mbrobbel March 24, 2025 18:19
@alamb
Copy link
Contributor Author

alamb commented Mar 24, 2025

Hi @mbrobbel - any chance you have some time to review this PR (it should be pretty familiar given you wrote the code originally ;) )

mbrobbel
mbrobbel approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this.

@alamb alamb merged commit a2cc426 into apache:main Mar 25, 2025
29 checks passed
@alamb
Copy link
Contributor Author

alamb commented Mar 25, 2025 •
edited
Loading

😅 it took a while but we made it

@alamb alamb deleted the alamb/update_rand_take2 branch March 25, 2025 18:06
@comphead
Copy link
Contributor

comphead commented Mar 26, 2025

what arrow release it is expected to go to?

@mbrobbel
Copy link
Member

mbrobbel commented Mar 26, 2025

what arrow release it is expected to go to?

Next major release:

@comphead
Copy link
Contributor

comphead commented Mar 26, 2025

Thanks @mbrobbel

@alamb
Copy link
Contributor Author

alamb commented Mar 26, 2025

I'll try and make the 55 release next week if possible (first week of march) so we can get the encryption and filter pushdown improvement enabled sooner rather than later

@alamb alamb mentioned this pull request May 8, 2025
Closed
8 tasks
wiedld pushed a commit to influxdata/arrow-rs that referenced this pull request May 21, 2025
@alamb @mbrobbel @wiedld
Update rand requirement from 0.8 to 0.9 (try 2) (apache#7126)
ed3e8ad 
* Reapply "Update rand requirement from 0.8 to 0.9 (apache#7045)"

This reverts commit 71a4770.

* Revert "downgrade API"

This reverts commit 352e249.

* Apply suggestions from code review

Co-authored-by: Matthijs Brobbel <[email protected]>

---------

Co-authored-by: Matthijs Brobbel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrobbel mbrobbel mbrobbel approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate next-major-release the PR has API changes and it waiting on the next major version parquet Changes to the parquet crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb @comphead @mbrobbel