Skip to content

GH-46314: [C++][Parquet] Fix valgrind error when collecting parameterized tests for MakeWKBPoint #46320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented May 5, 2025

Rationale for this change

The nightlies for valgrind report a use of an uninitialized value around MakeWKBPointTestCase.

What changes are included in this PR?

A custom printer was added for the test case. I believe the sanitizer error was occurring because the bytes of the std::vector were being printed (and may not have been initialized yet).

Are these changes tested?

Yes

Are there any user-facing changes?

No!

Copy link

github-actions bot commented May 5, 2025

⚠️ GitHub issue #46314 has been automatically assigned in GitHub to PR creator.

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-conda-cpp-valgrind

Copy link

github-actions bot commented May 5, 2025

Revision: c295bd5

Submitted crossbow builds: ursacomputing/crossbow @ actions-ced901251e

Task Status
test-conda-cpp-valgrind GitHub Actions

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-conda-cpp-valgrind

Copy link

github-actions bot commented May 5, 2025

Revision: ff7c450

Submitted crossbow builds: ursacomputing/crossbow @ actions-7cd4146254

Task Status
test-conda-cpp-valgrind GitHub Actions

@paleolimbot
Copy link
Member Author

It looks like there are other valgrind failures here...I will take a closer look tomorrow, but I think this fixes that particular issue!

@paleolimbot paleolimbot marked this pull request as ready for review May 6, 2025 04:55
@paleolimbot paleolimbot requested a review from wgtmac as a code owner May 6, 2025 04:55
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paleolimbot paleolimbot merged commit f25fab4 into apache:main May 6, 2025
32 of 35 checks passed
@paleolimbot paleolimbot removed the awaiting committer review Awaiting committer review label May 6, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f25fab4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants