Skip to content

[Bug](agg-state) fix agg state inner type not conversioned #50418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Apr 25, 2025

What problem does this PR solve?

drop table if exists t01;
create table t01(id int, decimal_col agg_state<sum(decimal(20,6))> generic) properties ("replication_num" = "1");
insert into t01 values (1, sum_state(10.1)), (1, sum_state(20.1)), (2, sum_state(10.2)), (2, sum_state(11.0));
select sum_merge(decimal_col) from t01 group by id;

[18:36]MySQL root@172.20.48.119:test_agg_state> select sum_merge(decimal_col) from t01 group by id; (1105, "errCode = 2, detailMessage = (172.20.48.119)[INTERNAL_ERROR]AggState(function_name=sum,result_is_nullable=true,arguments=[Nullable(Decimal(27, 9))],be_exec_version=8)'s expect return type is Nullable(Decimal(27, 9)), but input Nullable(Decimal(76, 6))") [18:36]MySQL root@172.20.48.119:test_agg_state>

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Sorry, something went wrong.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 30, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit a68c8df into apache:master Apr 30, 2025
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 30, 2025
### What problem does this PR solve?


drop table if exists t01;
create table t01(id int, decimal_col agg_state<sum(decimal(20,6))>
generic) properties ("replication_num" = "1");
insert into t01 values (1, sum_state(10.1)), (1, sum_state(20.1)), (2,
sum_state(10.2)), (2, sum_state(11.0));
select sum_merge(decimal_col) from t01 group by id;
 

[18:36]MySQL root@172.20.48.119:test_agg_state> select
sum_merge(decimal_col) from t01 group by id; (1105, "errCode = 2,
detailMessage =
(172.20.48.119)[INTERNAL_ERROR]AggState(function_name=sum,result_is_nullable=true,arguments=[Nullable(Decimal(27,
9))],be_exec_version=8)'s expect return type is Nullable(Decimal(27,
9)), but input Nullable(Decimal(76, 6))") [18:36]MySQL
root@172.20.48.119:test_agg_state>


### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
dataroaring pushed a commit that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants