-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37410][runtime/metrics] Split level Watermark metrics #26276
base: master
Are you sure you want to change the base?
Conversation
@flinkbot run azure |
<tr> | ||
<td>watermark.activeTimeMsPerSecond</td> | ||
<td> | ||
The time (in milliseconds) this split is active (i.e. not paused due to watermark alignment or idle due to idleness detection) per second. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:this split is active -> this split has been active
<tr> | ||
<td>watermark.accumulatedActiveTimeMs</td> | ||
<td> | ||
Accumulated time (in milliseconds) this split was active since registered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: since registered -> since it was registered.
is this updated every second? If so then we should say that
same for the next 2 , it was and full stop
What is the purpose of the change
This pull request adds split level watermark metrics, covering watermark progress and per-split state gauges (active, idle and paused)
The change is widely described in FLIP-513: Split-level Watermark Metrics
Brief change log
InternalSourceSplitMetricGroup
introduced as a sub-group of OperatorMetricGroup, containing a watermark reference and pauseable timers for states.WatermarkUpdateListener
usages were updated to match the new signature.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yes (metrics)Documentation