-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37460][state] Make state processor API checkpoint ID configurable #26299
base: release-1.20
Are you sure you want to change the base?
Conversation
pom.xml
Outdated
<version>0.17.1</version> | ||
<version>0.18.5</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is new!☝️The following error is shown by japicmp:
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.17.1:cmp (default) on project flink-state-processor-api: There is at least one incompatibility: org.apache.flink.state.api.OperatorTransformation.bootstrapWith(org.apache.flink.api.java.DataSet,long):CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.flink.state.api.OperatorTransformation.bootstrapWith(org.apache.flink.streaming.api.datastream.DataStream,long):CLASS_GENERIC_TEMPLATE_CHANGED -> [Help 1]
The problem is caused by siom79/japicmp#368.
The issue behind can be solved the following ways:
- We increase the jacmp version where the mentioned bug has been resolved
- We add class to the whitelist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gaborgsomogyi How about bump this on master branch and backport it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with anything since this is ugly here. Separating the intentions is good in general so doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it's merged then we're going to have the possibility to remove this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no more in this change.
2f9792d
to
f4ec8ba
Compare
f4ec8ba
to
b3b13c5
Compare
@grzegorz-liter-getindata can you please check your side? |
@gaborgsomogyi yeah, give me couple of days thou please. Is there some date set for 1.20.2 release we need to met? |
This is backport of #26285.
What is the purpose of the change
At the moment the state processor API is using hardcoded
0
as checkpoint ID.In this PR I've made it configurable and savepoint modification keeps the original checkpoint ID.
Brief change log
Made state processor API checkpoint ID configurable and savepoint modification keeps the original ID.
Verifying this change
Changed automated tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation