General support for metadata columns + implementation for _pos
#1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream
…lds at arrow-rs 57.0
vustef
commented
Oct 27, 2025
| /// | ||
| /// Metadata columns are virtual columns that provide metadata about the rows, | ||
| /// such as file paths or row positions. These come from https://iceberg.apache.org/spec/#identifier-field-ids | ||
| pub fn with_metadata_columns(mut self, metadata_columns: Vec<String>) -> Self { |
There was a problem hiding this comment.
Need some validation here, for allowed column names. Or type safety, to pick columns from enum (possibly preventing duplication?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#1765
What changes are included in this PR?
Are these changes tested?