Replaces old docs project with modern 'no-targets' msbuild project #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirwin
approved these changes
Oct 23, 2024
|
Thanks Shannon. We also need this for the |
|
Agreed, let's do a separate PR for that. This can be a template for how to do it if @Shazwazza is unavailable to finish that one. |
|
Excellent. I didn't even know about the modern 'no-targets' msbuild project, I had to research it. It seems like a great fit for holding DocFx-based templates and associated files. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old docs project in the sln was based on the old .net framework 'websites' since msbuild/.net didn't have a nice way to have a project that just contains files.
Now, with the no-targets SDK project type, this is possible.
This just replaces the old docs project with a new one that uses the no-targets SDK project type