-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/armv7-a/r: unifying boot flow #15624
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. Here's why and how to fix it: Missing Information in Summary:
Missing Information in Impact:
Missing Information in Testing:
Example of an improved description:
NuttShell (NSH)
NuttShell (NSH)
This improved example provides more context, explains the "why," and includes more specific details about the testing environment and results, making it much more likely to be accepted. Remember to replace the placeholders with your actual information. |
c96c087
to
e5e3af5
Compare
e5e3af5
to
6b6fd23
Compare
This attempts to unify the boot flow of armv7-a and armv7-r so that nx_start() is kicked by C-level arm_boot() directly. Signed-off-by: Yanfeng Liu <[email protected]>
6b6fd23
to
12af53a
Compare
|
||
mov lr, #0 /* LR = return address (none) */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it better that we modify armv7-r and armv8-r instead?
@yf13 I think it will impact at least these boards: pcDuino Did you try it on these boards? I have a pcDuino here, I will try it on that board. |
@acassis, no I didn't because I couldn't. Seeing that |
Summary
This tries to unify the boot flow of armv7-a and armv7-r so that nx_start() is directly kicked off from C-level boot function.
This is a breaking change as there maybe downstream armv7-a devices where arm_boot() returns to arm_head.S. They can be updated similar to
qemu_boot.c
andimx6_boot.c
.Impacts
armv7-a devices.
Testing