Support XML string and file path for NDAttributesFile#503
Merged
MarkRivers merged 1 commit intoareaDetector:masterfrom Feb 9, 2024
Merged
Conversation
coretl
approved these changes
Feb 9, 2024
Contributor
|
@MarkRivers are we ok to merge this? |
Member
|
Yes, doing it now. |
callumforrester
added a commit
to callumforrester/ADCore
that referenced
this pull request
Aug 22, 2025
Following areaDetector#503 the NDAttributesFile record can also directly contain an XML string, however the record is still limited to 256 characters, which may not be enough to accomodate a large blob of XML. This adds a macro, NDATTRIBUTES_XML_CHAR_LIMIT, with a default of 256, so IOCs can be configured to accomodate larger blobs of XML.
callumforrester
added a commit
to callumforrester/ADCore
that referenced
this pull request
Aug 22, 2025
Following areaDetector#503 the NDAttributesFile record can also directly contain an XML string, however the record is still limited to 256 characters, which may not be enough to accomodate a large blob of XML. This adds a macro, NDATTRIBUTES_XML_CHAR_LIMIT, with a default of 256, so IOCs can be configured to accomodate larger blobs of XML.
callumforrester
added a commit
to callumforrester/ADCore
that referenced
this pull request
Aug 26, 2025
Following areaDetector#503 the NDAttributesFile record can also directly contain an XML string, however the record is still limited to 256 characters, which may not be enough to accomodate a large blob of XML. This adds a macro, XMLSIZE, with a default of 256, so IOCs can be configured to accomodate larger blobs of XML.
callumforrester
added a commit
to DiamondLightSource/ADCore
that referenced
this pull request
Aug 26, 2025
Following areaDetector#503 the NDAttributesFile record can also directly contain an XML string, however the record is still limited to 256 characters, which may not be enough to accomodate a large blob of XML. This adds a macro, XMLSIZE, with a default of 256, so IOCs can be configured to accomodate larger blobs of XML.
GDYendell
pushed a commit
to DiamondLightSource/ADCore
that referenced
this pull request
Aug 26, 2025
Following areaDetector#503 the NDAttributesFile record can also directly contain an XML string, however the record is still limited to 256 characters, which may not be enough to accomodate a large blob of XML. This adds a macro, XMLSIZE, with a default of 256, so IOCs can be configured to accomodate larger blobs of XML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #502 @coretl Tested against the example XML from ADCore/ADApp/ADSrc/asynNDArrayDriver.cpp