nall: Namespace noinline macro #1674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change spun off from continuing build system work.
There, we've found that precompiling the
ares/ares.hppheader can speed up compile times for the emulator cores by 30-35%. Doing so, however, leads to a few collisions:Hashtype, which variously resolves to aHashin its own namespace as well as nall's namespace.noinlinemacro conflicts with similar definitions present inxxhash.For parallel-rdp, we can simply skip precompiled headers for the conflicting files; parallel-rdp does not use anything in the
ares/ares.hppheader, so including it there is unnecessary anyway.This change resolves the second set of collisions by putting nall's noinline preprocessor macro into its own namespace.
There are many macros remaining that are not namespaced. I did not proceed in namespacing them for this PR, because there are a lot of them, and it would be a fairly significant code style change that probably merits further discussion (not to mention, it will be a decent amount of work). However, in this instance, there is (or will be) a material benefit that probably trumps the minor style issue.