-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bitnami/redis-exporter): Update public.ecr.aws/bitnami/redis-exporter Docker tag to v1.67.0 #3104
base: main
Are you sure you want to change the base?
chore(bitnami/redis-exporter): Update public.ecr.aws/bitnami/redis-exporter Docker tag to v1.67.0 #3104
Conversation
#3072 made this PR. It seems that we needed to enhance https://github.com/argoproj/argo-helm/blob/main/renovate.json at the same time. 🙃 |
59f524e
to
0e67360
Compare
|
🫠 |
Bitnami’s charts went oci-only about a month ago. Did we update to reflect that? If not, this would explain the error. |
There was a PR to run Renovate against tags in values.yaml and we needed to handle scripts for it. But here is the result. 🫠 |
It looks like https://github.com/argoproj/argo-helm/blob/main/scripts/renovate-bump-version.sh Is only designed to look at our internal charts, not third party dependencies. It looks like renovate it running this script expecting to be able to change the upstream chart.yaml. |
The script needs to be refactored so that it understands that it’s changing our argocd values file and not the third party chart. |
The issue lies in the depname variable and how it’s then used. |
I will fix the script in #3106 🙋 |
The initial PR (#3072) about dependencies inside values.yaml introduced a new PR naming pattern. Our idea was to name PRs according to conventional commits using the chart names as the scopes:
Now we have the dependency in the conventional commit scope. I think we should address this as well. Ref in contributors guide: |
0e49066
to
c3ac910
Compare
…porter Docker tag to v1.67.0 Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
c3ac910
to
12c3e29
Compare
This PR contains the following updates:
1.58.0
->1.67.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.