Pseduo-remove MapToCurve::new, renamed to check_parameters #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapToCurve::new seemingly originates from a more runtime oriented elliptic curve crate: https://github.com/armfazh/redox-ecc/blob/master/src/ellipticcurve.rs#L36 Arguably test_parameters should be inherent methods, invoked by whoever defined the parameters, but maybe not? I left the trait method for now.
Co-authored-by: Pratyush Mishra <[email protected]>
Co-authored-by: Pratyush Mishra <[email protected]>
Co-authored-by: Pratyush Mishra <[email protected]>
Co-authored-by: Pratyush Mishra <[email protected]>
rustfmt is wrong that f()? should be preferred over f() ?, as errors paths should often be highlighted, but nobody merged that fix yet, so whatever. rust-lang/rustfmt#5595
burdges
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
6 tasks
mmagician
reviewed
Sep 11, 2023
| @@ -24,7 +24,7 @@ where | |||
| M2C: MapToCurve<T>, | |||
| { | |||
| field_hasher: H2F, | |||
| curve_mapper: M2C, | |||
| _curve_mapper: PhantomData<M2C>, | |||
There was a problem hiding this comment.
how about bundling the two phantoms, then:
_phantom: PhantomData<(T, M2C)>,
There was a problem hiding this comment.
I forget if this goes away later or not, but maybe it stays, so sure let's merge them.
| @@ -79,13 +79,13 @@ pub trait WBConfig: SWCurveConfig + Sized { | |||
| } | |||
|
|
|||
| pub struct WBMap<P: WBConfig> { | |||
| swu_field_curve_hasher: SWUMap<P::IsogenousCurve>, | |||
| swu_field_curve_hasher: PhantomData<SWUMap<P::IsogenousCurve>>, | |||
There was a problem hiding this comment.
That's not needed anymore IIUC?
I think we can remove this field, and change curve_params to:
phantom: PhantomData<P>,
There was a problem hiding this comment.
Almost:
fn() -> Pis covariant inPhttps://doc.rust-lang.org/nomicon/subtyping.htmlSWUMap<P::IsogenousCurve>isfn() -> P::IsogenousCurvewhich is covariant inP::IsogenousCurve.
We know the story here of course, but in principle you cannot say the associated type P::IsogenousCurve is covariant in P. It's be fine to do this in practice, given it's all static in practice, but maybe leave it for now?
There was a problem hiding this comment.
Sure, it also doesn't affect the user's end.
Pratyush
approved these changes
Sep 11, 2023
mmagician
approved these changes
Sep 12, 2023
mmagician
pushed a commit
to mmagician/algebra
that referenced
this pull request
Oct 4, 2023
…rkworks-rs#679)" This reverts commit 85546e4.
Pratyush
pushed a commit
that referenced
this pull request
Oct 4, 2023
aleasims
pushed a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
…rs#679) Co-authored-by: Pratyush Mishra <[email protected]> Co-authored-by: ¨Jeff <¨[email protected]¨>
aleasims
pushed a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
Co-authored-by: Jeff Burdges <[email protected]>
aleasims
added a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
This reverts commit bd13d1e.
aleasims
added a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
…rkworks-rs#679)" This reverts commit 40e8b67.
mmagician
added a commit
to mmagician/algebra
that referenced
this pull request
Oct 31, 2023
This reverts commit 5dfeedf.
drskalman
added a commit
to w3f/arkworks-algebra
that referenced
this pull request
Jan 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 14, 2024
* Implement Elligator2 hash to curve for Twisted Edward curves * - Update the pull request number for Elligator2 map in CHANGELOG.md - Fix fmt errors in other parts of the repo. * Remove diagnostic `println`s * Remove irrelevant comment as elligator is not based on pasta Co-authored-by: mmagician <[email protected]> * Referencing RFC9380 for hash-to-curve instead of the draft, plus comment clean up. Co-authored-by: mmagician <[email protected]> * Cite new reference for hash-to-curve Co-authored-by: mmagician <[email protected]> * Make sig0 function of elligator2 map boolean instead of 0u8, 1u8 Co-authored-by: mmagician <[email protected]> * Move parity method from `curve_maps::swu` to `curve_maps` as it is used by both swu and elligator. * Remove map-to-curve sanity checks from release build. * cargo fmt * - apply new naming convention for map2curves - rename `new` to `check_parameters` * fix the documentation for `Elligator2Map::check_parameters` * Call elements of the field `element` not `point` in SWU hash-to-curve map * Mention moving of `parity` function in breaking changes. * fmt * move \#659 from pending bto features in `CHANGELOG.md` * bring back `new` and MapToCurve Object. * `cargo fmt` * Move Elligator2 pre-computatable values to `Elligator2Config` * Pre-computatable Elligator2 test example * Move Elligator2 `MapToCurve` implementation to its own folder. * Fix reference to the Elligator paper * Make elligator curve map a static object following revert of revert of #679 * Remove whitespace * Stricter check on SWU parameters Co-authored-by: Marcin <[email protected]> --------- Co-authored-by: mmagician <[email protected]> Co-authored-by: Pratyush Mishra <[email protected]> Co-authored-by: Pratyush Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MapToCurve::new seemingly originates from a more runtime oriented elliptic curve crate: https://github.com/armfazh/redox-ecc/blob/master/src/ellipticcurve.rs#L36
Arguably test_parameters should be inherent methods, invoked by whoever defined the parameters, but maybe not? I left the trait method for now. I suspect the hash-to-curve code would benefit form a wider more idiomatic rewrite btw.
Rebase of #627 but also moved to personal github, so maintainers could make changes. See previous discussion: #627 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer