Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pseduo-remove MapToCurve::new, renamed to check_parameters #679

Merged
merged 10 commits into from
Sep 12, 2023
Merged

Pseduo-remove MapToCurve::new, renamed to check_parameters #679

merged 10 commits into from
Sep 12, 2023

Commits on Sep 8, 2023

  1. Avoid unused subdirectories

    ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bb39f36 View commit details
    Browse the repository at this point in the history

  2. Pseduo-remove MapToCurve::new, renamed to test_parameters 

    MapToCurve::new seemingly originates from a more runtime oriented
elliptic curve crate:
https://github.com/armfazh/redox-ecc/blob/master/src/ellipticcurve.rs#L36

Arguably test_parameters should be inherent methods, invoked by whoever
defined the parameters, but maybe not?  I left the trait method for now.
    ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bde97bf View commit details
    Browse the repository at this point in the history

  3. Update ec/src/hashing/curve_maps/wb.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    2f966d6 View commit details
    Browse the repository at this point in the history

  4. Update ec/src/hashing/curve_maps/swu.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    682feca View commit details
    Browse the repository at this point in the history

  5. Update ec/src/hashing/map_to_curve_hasher.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    784f3ef View commit details
    Browse the repository at this point in the history

  6. Update ec/src/hashing/curve_maps/swu.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    472bd01 View commit details
    Browse the repository at this point in the history

  7. Two more renames

    ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    201940b View commit details
    Browse the repository at this point in the history

  8. make rustfmt happier

    ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    69812fb View commit details
    Browse the repository at this point in the history

  9. rustfmt is wrong on this one but whatever 

    rustfmt is wrong that f()? should be preferred over f() ?, as errors paths should often be highlighted, but nobody merged that fix yet, so whatever. 
rust-lang/rustfmt#5595
    @burdges
    burdges authored and ¨Jeff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0afbdfc View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Request by mmarcin

    ¨Jeff committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ee43eea View commit details
    Browse the repository at this point in the history