deny large stack frames #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
force-pushed
the
arlyon/large-stack-frames
branch
from
95fb1ca to
acfe5c9
Compare
arlyon
force-pushed
the
arlyon/large-stack-frames
branch
2 times, most recently
from
6bf0bbd to
9331475
Compare
arlyon
force-pushed
the
arlyon/large-stack-frames
branch
from
9331475 to
7211499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #771 (ty @augustoccesar for fix suggestion).
270 if statements is not great... however it is no worse than what we had before. Considered a PHF but this is not particularly hot code.
Checklist
cargo make fmt