test if we can update python version in tests #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Feb 4, 2025
| @@ -8,15 +8,15 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ['3.8', '3.10', '3.12'] | |||
| python-version: ['3.9', '3.11', '3.13'] | |||
| # currently there is conflict between tf, oneflow and paddle in protobuf versions. | |||
| # cupy is not tested because it demands gpu | |||
| # oneflow testing is dropped, see details at https://github.com/Oneflow-Inc/oneflow/issues/10340 | |||
| # paddle was switched off because of divergence with numpy in py3.10, paddle==2.6.1 | |||
| # The last pytensor release that supports python 3.8 doesn't include einsum, so we skip that combination. | |||
There was a problem hiding this comment.
Update to mention the opposite, that last pytensor does not yet support python3.13?
There was a problem hiding this comment.
will do if end with 3.13 working. Figuring out blockers right now.
|
Ugh python3.9 test also fails with PyTensor backend. We only pinned numpy < 2.0 later :( If you skip that it should work on 3.10, 3.11, 3.12. I don't think we support 3.13 yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.