Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test if we can update python version in tests #364

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test if we can update python version in tests #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cda914c
test if we can update python version in tests
arogozhnikov Feb 4, 2025
be2a175
skip pytensor in 3.13, couldn't install
arogozhnikov Feb 4, 2025
550f25b
update notebooks testing to 3.9 and 3.13
arogozhnikov Feb 4, 2025
4c6772e
3.13 -> 3.12
arogozhnikov Feb 4, 2025
7c2401a
separate testing inclusion for pytensor
arogozhnikov Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/run_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,21 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.10', '3.12']
python-version: ['3.9', '3.11', '3.12']
# currently there is conflict between tf, oneflow and paddle in protobuf versions.
# cupy is not tested because it demands gpu
# oneflow testing is dropped, see details at https://github.com/Oneflow-Inc/oneflow/issues/10340
# paddle was switched off because of divergence with numpy in py3.10, paddle==2.6.1
frameworks: ['numpy pytorch tensorflow jax']
# The last pytensor release that supports python 3.8 doesn't include einsum, so we skip that combination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to mention the opposite, that last pytensor does not yet support python3.13?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do if end with 3.13 working. Figuring out blockers right now.

frameworks: ['numpy pytorch tensorflow jax', 'pytensor']
exclude:
- python-version: '3.8'
# 3.9 -> does not have a pin to numpy < 2, but not compatible with numpy 2
# 3.13 -> not supported (yet)
include:
- python-version: '3.10'
frameworks: 'pytensor'
- python-version: '3.12'
frameworks: 'pytensor'


steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_notebooks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.12']
python-version: ['3.9', '3.12']

steps:
- uses: actions/checkout@v4
Expand Down