generator: Generate enums from vk_parse representation #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2021
MarijnS95
force-pushed
the
enum-vk-parse
branch
from
0d4baa4
to
543746c
Compare
MarijnS95
force-pushed
the
enum-vk-parse
branch
from
543746c
to
7644469
Compare
MaikKlein
reviewed
Apr 17, 2021
This change prepares for future additions in vk_parse fields ([1]) by converting over the enum generation path from vkxml. Most of the conversion is easy by repurposing the existing `EnumSpec` parsing logic from extension constants for all enumeration variants, with slight modifications to not bail when `extends` is not set which is specific to extension constants. As an (unintended) added bonus this unification of the `EnumSpec` codepath allows aliases (for backwards-compatible names) to be generated as discussed earlier in [2]. [1]: krolli/vk-parse#17 [2]: ash-rs#384 (comment)
All constant aliases for misspelled items (missing `_BIT` andsoforth) contain the text "backwards compatibility" or "Backwards-compatible alias".
These already have a match against the name they're aliasing, and some of the aliases are "deprecated" (since they're just typo fixups for backwards compatibility).
MarijnS95
force-pushed
the
enum-vk-parse
branch
from
7644469
to
ed8f401
Compare
MaikKlein
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #409merged already.This change prepares for future additions in vk_parse fields (1) by converting over the enum generation path from vkxml. Most of the conversion is easy by repurposing the existing
EnumSpecparsing logic from extension constants for all enumeration variants, with slight modifications to not bail whenextendsis not set which is specific to extension constants.As an (unintended) added bonus this unification of the
EnumSpeccodepath allows aliases (for backwards-compatible names) to be generated as discussed earlier in 2.@MaikKlein you're probably wondering by now why I'm not helping pushing generator2 over the finish line. Would you mind providing a status/progress update in #344 and clarify the reason behind removing
quote!()/syn, instead opting for manual string manipulation?