Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator: Generate enums from vk_parse representation #410

Merged
merged 4 commits into from
Apr 18, 2021
Merged

generator: Generate enums from vk_parse representation #410

merged 4 commits into from
Apr 18, 2021

Commits on Apr 17, 2021

  1. generator: Generate enums from vk_parse representation 

    This change prepares for future additions in vk_parse fields ([1]) by
converting over the enum generation path from vkxml.  Most of the
conversion is easy by repurposing the existing `EnumSpec` parsing logic
from extension constants for all enumeration variants, with slight
modifications to not bail when `extends` is not set which is specific to
extension constants.

As an (unintended) added bonus this unification of the `EnumSpec`
codepath allows aliases (for backwards-compatible names) to be generated
as discussed earlier in [2].

[1]: krolli/vk-parse#17
[2]: ash-rs#384 (comment)
    @MarijnS95
    MarijnS95 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    a4ea995 View commit details
    Browse the repository at this point in the history

  2. generator: Turn "backwards"-mentioning docs into deprecation notices 

    All constant aliases for misspelled items (missing `_BIT` andsoforth)
contain the text "backwards compatibility" or "Backwards-compatible
alias".
    @MarijnS95
    MarijnS95 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    06183a0 View commit details
    Browse the repository at this point in the history

  3. generator: Drop aliases whose name becomes identical after de-mangling

    @MarijnS95
    MarijnS95 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    426f81f View commit details
    Browse the repository at this point in the history

  4. generator: Remove aliases from const_debugs 

    These already have a match against the name they're aliasing, and some
of the aliases are "deprecated" (since they're just typo fixups for
backwards compatibility).
    @MarijnS95
    MarijnS95 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    ed8f401 View commit details
    Browse the repository at this point in the history