Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pass run condition to reusable workflow #9771

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Dec 24, 2024

Description

This PR resolves the issue raised in #9769 by alternative method.

This PR:

For the details, please refer to the comment here.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@mitsudome-r mitsudome-r requested a review from xmfcx December 24, 2024 22:14
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 24, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 24, 2024

Thanks, you need to do the same for the clang tidy one as well.

@mitsudome-r mitsudome-r force-pushed the modify-workflow-condition branch from 9540240 to 4b96407 Compare December 24, 2024 23:52
Comment on lines +72 to 74
if: ${{ always() }} # always run to provide report for status check
needs:
- build-and-test-differential-cuda
Copy link
Member Author

@mitsudome-r mitsudome-r Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to explicitly set "always()" condition to make sure that "clang-tidy-differential-cuda" job even when build-and-test-differential-cuda is not ran.

Check here for the details:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

When a job fails, any jobs that depend on the failed job are skipped and do not report a failure. A pull request that requires the check may not be blocked. To use a required check on a job that depends on other jobs, use the always() conditional expression in addition to needs, see Using jobs in a workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants