-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pass run condition to reusable workflow #9771
base: main
Are you sure you want to change the base?
ci: pass run condition to reusable workflow #9771
Conversation
…refoundation#9769)" This reverts commit 421ec7d.
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Thanks, you need to do the same for the clang tidy one as well. |
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
9540240
to
4b96407
Compare
if: ${{ always() }} # always run to provide report for status check | ||
needs: | ||
- build-and-test-differential-cuda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to explicitly set "always()" condition to make sure that "clang-tidy-differential-cuda" job even when build-and-test-differential-cuda is not ran.
Check here for the details:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
When a job fails, any jobs that depend on the failed job are skipped and do not report a failure. A pull request that requires the check may not be blocked. To use a required check on a job that depends on other jobs, use the always() conditional expression in addition to needs, see Using jobs in a workflow.
Description
This PR resolves the issue raised in #9769 by alternative method.
This PR:
run-condition
to the reusablebuild-and-test-diffirential.yaml
workflowFor the details, please refer to the comment here.
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.