Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): replace sstream to fmt for marker's text #9775

Merged

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Replacing ostringstream to fmt::format for text marker.

Related links

Parent Issue:

  • Link

How was this PR tested?

Build success.
Check lane change debug marker in PSIM.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 25, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.67%. Comparing base (3d53032) to head (0f61bef).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...vior_path_lane_change_module/src/utils/markers.cpp 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9775      +/-   ##
==========================================
+ Coverage   29.66%   29.67%   +0.01%     
==========================================
  Files        1450     1452       +2     
  Lines      108833   108848      +15     
  Branches    42740    42730      -10     
==========================================
+ Hits        32285    32303      +18     
  Misses      73375    73375              
+ Partials     3173     3170       -3     
Flag Coverage Δ *Carryforward flag
differential 20.90% <30.76%> (?)
total 29.68% <ø> (+0.01%) ⬆️ Carriedforward from 16d5cb1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkquda mkquda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit d4ced2a into autowarefoundation:main Dec 25, 2024
47 of 50 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the lc-sstream-to-fmt branch December 25, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants