-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ansible): added the spconv installation to ansible #5794
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Thanks! Could you fix https://github.com/autowarefoundation/autoware/actions/runs/13363617410/job/37317278911?pr=5794 errors? Also if it's ok with you we can move this to AWF, do you need any help on that? |
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Could you also add a playbook that only installs this role? For easy manual installation of only this role. |
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
ansible/roles/spconv/tasks/main.yaml
Outdated
- name: Download the cumm package | ||
ansible.builtin.get_url: | ||
mode: "0644" | ||
url: https://github.com/knzo25/spconv_cpp/releases/download/spconv_v{{ spconv_version }}%2Bcumm_v{{ cumm_version }}/cumm_{{ cumm_version }}_amd64.deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think arm64 workflow will fail after merge. We can release binaries for arm64 and get current system arch in ansible task file directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amadeuszsz
Created the assets in https://github.com/knzo25/spconv_cpp/releases
Annoyingly, the health-check fails for unrelated reasons. @amadeuszsz |
This one is caused by:
As for ARM support, I personally didn't build the ARM image on my machine before, please consult @youtalk @amadeuszsz @oguzkaganozt on this one 🙇♂️ And if you can manage, adding these detailed steps to documentation would be appreciated 😶🌫️ |
It seems this is expected |
Does TIER IV require this package to work in ARM/Jetson devices? If not maybe we can also make an exception and add it anyways and somehow disable it for ARM builds. It depends on how much additional work making it work for ARM requires though. @mitsudome-r @youtalk could you comment as well? |
… arm64 Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@xmfcx Once the PR is approved, but before merging, I will transfer the repo to the AWF (have done it before) and update the links. At that point, please add me as an admin so I can fix any problems down the line |
…red to them differently Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@knzo25 now created: Once that is merged, we'll bump the reference to this Universe repo from autoware.repos and then it should pass the health check. Finally waiting for: |
Description
As discussed in
Instead of a ros2 package, spconv could be installed as a deb package.
This PR adds its installation via ansible
How was this PR tested?
Run the setup script in my local machine
Notes for reviewers
None.
Effects on system behavior
None.