refactor(motion_velocity_planner): simplify insert stop point function #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <[email protected]>
maxime-clem
added
the
run:build-and-test-differential
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 78.75% 0.00% -78.76%
==========================================
Files 11 105 +94
Lines 193 7408 +7215
Branches 73 1342 +1269
==========================================
- Hits 152 0 -152
- Misses 11 7408 +7397
+ Partials 30 0 -30
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
youtalk
reviewed
Apr 16, 2025
planning/motion_velocity_planner/autoware_motion_velocity_planner/src/node.cpp
Outdated
Show resolved
Hide resolved
…ner/src/node.cpp Co-authored-by: Yutaka Kondo <[email protected]>
|
Could you explain how this modification is tested? |
youtalk
approved these changes
May 12, 2025
|
Thank you for your reviews. I will add a unit test when I find the time 🙏 |
|
@maxime-clem Do you have the time? If not, please test the node execution. |
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor change to simplify the function to add stop points to the motion velocity planner trajectory.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.