Skip to content

feat(planning_factor): add console output option #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 3, 2025

Description

Add console output option.
This feature is helpful for debbuging of some products where we can not get rosbag

with

    planning_factor_console_output:
      enable: true
      duration: 1000 # ms
planning_factor_console-2025-06-03_17.00.45.mp4

Related links

Parent Issue:

  • Link

How was this PR tested?

psim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jun 3, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 3, 2025
@kosuke55 kosuke55 force-pushed the feat/planning_factor_console_awf branch from bb9de3c to f58c7cd Compare June 3, 2025 08:20
@kosuke55 kosuke55 force-pushed the feat/planning_factor_console_awf branch from 3de23f6 to 54358e5 Compare June 3, 2025 11:28
Signed-off-by: kosuke55 <[email protected]>

fix param json

Signed-off-by: kosuke55 <[email protected]>

fix param json

Signed-off-by: kosuke55 <[email protected]>

snake_case

Signed-off-by: kosuke55 <[email protected]>

set default

Signed-off-by: kosuke55 <[email protected]>
@kosuke55 kosuke55 force-pushed the feat/planning_factor_console_awf branch from 9e0198d to 8ce233e Compare June 6, 2025 06:28
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.26%. Comparing base (eb0a0df) to head (8ce233e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ing_factor_interface/planning_factor_interface.hpp 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   46.98%   48.26%   +1.28%     
==========================================
  Files         285      287       +2     
  Lines       18957    22310    +3353     
  Branches     8015    10211    +2196     
==========================================
+ Hits         8906    10769    +1863     
- Misses       9264    10638    +1374     
- Partials      787      903     +116     
Flag Coverage Δ *Carryforward flag
differential 33.57% <53.33%> (?)
total 46.97% <ø> (-0.01%) ⬇️ Carriedforward from eb0a0df

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jun 9, 2025

@satoshi-ota @soblin could you review this PR?

@satoshi-ota
Copy link
Contributor

LGTM

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jun 9, 2025

@kyoichi-sugahara @shmpwk @maxime-clem @youtalk
could you check as code owner?

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jun 9, 2025

@mitsudome-r @xmfcx @youtalk
could you please review as autoware_core_planning code onwner? 🙏

image

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright 👍

@kosuke55 kosuke55 merged commit 896c82a into autowarefoundation:main Jun 9, 2025
26 of 28 checks passed
@kosuke55 kosuke55 deleted the feat/planning_factor_console_awf branch June 9, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants