Skip to content

fix(obstacle_stop): fix for failing scenario #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PanConChicharron
Copy link
Contributor

@PanConChicharron PanConChicharron commented Jul 8, 2025

Description

Changes to the obstacle-stop param for the minimum velocity parameter below which the opposing vehicle handling is trigerred.

This change was made to address an issue with a failing scenario where due to a bug with prediction, an obstacle ahead that slowly comes to a stop is predicted to eventually move in reverse, causing the stop-point to drastically shift backward.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Arjun Jagdish Ram <[email protected]>
Copy link

github-actions bot commented Jul 8, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@PanConChicharron PanConChicharron added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 8, 2025
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.37%. Comparing base (39374a4) to head (562758b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   47.37%   47.37%           
=======================================
  Files         312      312           
  Lines       20040    20040           
  Branches     8705     8705           
=======================================
  Hits         9494     9494           
  Misses       9721     9721           
  Partials      825      825           
Flag Coverage Δ *Carryforward flag
differential 2.53% <ø> (?)
total 47.37% <ø> (ø) Carriedforward from 39374a4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mitsudome-r
Copy link
Member

mitsudome-r commented Jul 8, 2025

@PanConChicharron Thanks for the PR, but could you make sure that the description is written properly so that OSS contributors can know what you are trying to fix with this PR? The link you provided is only visible from TIER IV.

@PanConChicharron
Copy link
Contributor Author

@PanConChicharron Thanks for the PR, but could you make sure that the description is written properly so that OSS contributors can know what you are trying to fix with this PR? The link you provided is only visible from TIER IV.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants