Skip to content

chore(motion_velocity_planner): replace "loadplugin" by autoware_internal_debug_msgs::srv::String #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jul 23, 2025

Description

We align the plugin handling in motion_velocity_planner with that of behavior_velocity_planner.

This is motivated by building LoadPlugin cause confusing ./install/ directory as follows.

workspace/install/autoware_motion_velocity_planner/include/
├── autoware
│   └── motion_velocity_planner
└── autoware_motion_velocity_planner
    └── autoware_motion_velocity_planner
        ├── msg
        └── srv
            └── detail

Then the dependency resolve to workspace/install/autoware_motion_velocity_planner/include/autowre/motion_velocity_planner will be fail.

Related links

This change is required by #572

How was this PR tested?

tier4 scenario_test

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jul 23, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/replace_LoadPlugin branch from f51b4ef to 117717d Compare July 24, 2025 07:20
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review July 24, 2025 07:22
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 24, 2025
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.80%. Comparing base (4f40b62) to head (117717d).

Files with missing lines Patch % Lines
...nner/autoware_motion_velocity_planner/src/node.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   47.80%   47.80%           
=======================================
  Files         313      313           
  Lines       20080    20080           
  Branches     8738     8738           
=======================================
  Hits         9599     9599           
  Misses       9660     9660           
  Partials      821      821           
Flag Coverage Δ *Carryforward flag
differential 2.59% <0.00%> (?)
total 47.81% <ø> (+<0.01%) ⬆️ Carriedforward from 4f40b62

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines -9 to -10
"srv/LoadPlugin.srv"
"srv/UnloadPlugin.srv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The srv folder can be completely deleted from the package as well

@mitsudome-r
Copy link
Member

mitsudome-r commented Jul 24, 2025

This is motivated by building LoadPlugin cause confusing ./install/ directory.

Could you provide more detail on this?
autoware_internal_debug_msgs is mainly for debugging purpose, and if we already have a service for specific purpose, I think it's better to use them instead.

@yuki-takagi-66
Copy link
Contributor Author

@mitsudome-r
I've documented what I know regarding the build.
Alternatively, could we port srv to autoware_internal_msgs/autoware_internal_planning_msgs?

@mitsudome-r
Copy link
Member

Thanks for adding the description. I will also look into why the dependency cannot be resolved properly as well to see if there are any other workarounds.
If I cannot find anything, I still rather prefer to put the LoadPlugin message under autoware_internal_msgs/autoware_internal_planning_msgs instead of replacing it with the autoware_internal_debug_msgs/srgv/String

@yuki-takagi-66 yuki-takagi-66 marked this pull request as draft July 24, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants