-
Notifications
You must be signed in to change notification settings - Fork 88
chore(motion_velocity_planner): replace "loadplugin" by autoware_internal_debug_msgs::srv::String #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(motion_velocity_planner): replace "loadplugin" by autoware_internal_debug_msgs::srv::String #582
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: yuki-takagi-66 <[email protected]>
f51b4ef
to
117717d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 47.80% 47.80%
=======================================
Files 313 313
Lines 20080 20080
Branches 8738 8738
=======================================
Hits 9599 9599
Misses 9660 9660
Partials 821 821
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
"srv/LoadPlugin.srv" | ||
"srv/UnloadPlugin.srv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The srv
folder can be completely deleted from the package as well
Could you provide more detail on this? |
@mitsudome-r |
Thanks for adding the description. I will also look into why the dependency cannot be resolved properly as well to see if there are any other workarounds. |
Description
We align the plugin handling in motion_velocity_planner with that of behavior_velocity_planner.
This is motivated by building LoadPlugin cause confusing ./install/ directory as follows.
Then the dependency resolve to
workspace/install/autoware_motion_velocity_planner/include/autowre/motion_velocity_planner
will be fail.Related links
This change is required by #572
How was this PR tested?
tier4 scenario_test
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.