Skip to content

fix(path_generator): merge waypoint groups with shared overlap interval #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mitukou1109
Copy link
Contributor

@mitukou1109 mitukou1109 commented Jul 25, 2025

Description

⚠️ This PR must be merged at the same time with autowarefoundation/autoware_launch#1576 ⚠️

This PR fixes waypoint grouping in case adjacent waypoint groups share their overlap interval (partly or entirely).

Before:
waypoint_group_overlap_interval_determination (コピー) drawio

After:
waypoint_grouping drawio

Related links

Internal: https://star4.slack.com/archives/C0575HP7NJG/p1753246578053939?thread_ts=1753246357.263529&cid=C0575HP7NJG

How was this PR tested?

Psim

Screencast.from.2025.07.25.16.17.46.webm

Notes for reviewers

None.

Interface changes

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Removed waypoint_group.separation_threshold double 1.0 Maximum distance at which consecutive waypoints are considered to belong to the same group [m]

Modifications

Version Parameter Name Type Default Value Description
Old waypoint_group.interval_margin_ratio double 10.0 Ratio for determining length of switching section from centerline to waypoints
New waypoint.connection_gradient_from_centerline double 10.0 Gradient for connecting centerline and user-defined waypoints

Effects on system behavior

None.

Copy link

github-actions bot commented Jul 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sasakisasaki sasakisasaki added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 25, 2025
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.75%. Comparing base (4ecfe7b) to head (4481cbd).

Files with missing lines Patch % Lines
planning/autoware_path_generator/src/utils.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   47.78%   47.75%   -0.04%     
==========================================
  Files         313      313              
  Lines       20088    20099      +11     
  Branches     8746     8747       +1     
==========================================
- Hits         9599     9598       -1     
- Misses       9668     9680      +12     
  Partials      821      821              
Flag Coverage Δ *Carryforward flag
differential 21.60% <20.00%> (?)
total 47.79% <ø> (+<0.01%) ⬆️ Carriedforward from 4ecfe7b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: mitukou1109 <[email protected]>
@mitukou1109
Copy link
Contributor Author

mitukou1109 commented Jul 25, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants