Skip to content

chore(autoware_internal_planning_msgs): unifiy module load srv #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jul 24, 2025

Description

Currently, behavior_velocity and motion_velocity depend on separate message definitions located at:

behavior_velocity: https://github.com/autowarefoundation/autoware_internal_msgs/blob/2c0323d64cc536cb1e70488349c853292b751ee0/autoware_internal_debug_msgs/srv/String.srv

motion_velocity: https://github.com/autowarefoundation/autoware_core/tree/1.3.0/planning/motion_velocity_planner/autoware_motion_velocity_planner/srv

We unify these by defining them within autoware_internal_planning_msgs.

How was this PR tested?

see core PR

Notes for reviewers

We have to merge by the following order

  1. add new srv chore(autoware_internal_planning_msgs): unifiy module load srv #76
  2. change to use new srv chore(motion_velocity_planner, behavior_velocity_planner): unifiy module load srv autoware_core#585
  3. delete unused srv 0a45787

Effects on system behavior

None.

Copy link

github-actions bot commented Jul 24, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review July 24, 2025 10:51
@yuki-takagi-66 yuki-takagi-66 changed the title chore(autoware_internal_planning_msgs): port srv LoadPlugin chore(autoware_internal_planning_msgs): port LoadPlugin Jul 24, 2025
@yuki-takagi-66 yuki-takagi-66 changed the title chore(autoware_internal_planning_msgs): port LoadPlugin chore(autoware_internal_planning_msgs): unifiy module load srv Jul 24, 2025
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Run build-and-test-differential workflow label Jul 25, 2025
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
This reverts commit 0a45787.

Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/port-load_plugin branch from 1c14072 to 2864a78 Compare July 25, 2025 04:13
@mitsudome-r mitsudome-r merged commit ac2c9dc into autowarefoundation:main Jul 25, 2025
10 checks passed
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (a701d19) to head (2864a78).
Report is 59 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##            main   #76    +/-   ##
====================================
  Coverage   0.00%     0            
====================================
  Files         12     0    -12     
  Lines        391     0   -391     
====================================
+ Misses       391     0   -391     
Flag Coverage Δ
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Run build-and-test-differential workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants