chore(motion_velocity_planner, behavior_velocity_planner): unifiy module load srv #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yuki-takagi-66
force-pushed
the
takagi/port-load_plugin
branch
2 times, most recently
from
ba42a31 to
f316cbf
Compare
yuki-takagi-66
requested review from
mkquda,
maxime-clem,
youtalk,
a team,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo and
tkimura4
as code owners
takayuki5168
approved these changes
Jul 24, 2025
Signed-off-by: yuki-takagi-66 <[email protected]>
yuki-takagi-66
force-pushed
the
takagi/port-load_plugin
branch
from
f316cbf to
03fe42c
Compare
yuki-takagi-66
added
the
run:build-and-test-differential
maxime-clem
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, behavior_velocity and motion_velocity depend on separate message definitions located at:
behavior_velocity: https://github.com/autowarefoundation/autoware_internal_msgs/blob/2c0323d64cc536cb1e70488349c853292b751ee0/autoware_internal_debug_msgs/srv/String.srv
motion_velocity: https://github.com/autowarefoundation/autoware_core/tree/1.3.0/planning/motion_velocity_planner/autoware_motion_velocity_planner/srv
We unify these by defining them within autoware_internal_planning_msgs.
Related links
autowarefoundation/autoware_internal_msgs#76
How was this PR tested?
Notes for reviewers
Interface changes
see autowarefoundation/autoware_internal_msgs#76
Effects on system behavior
None.