Fix the shutdownDelay to occur after status = STOPPING #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a regression bug in Helidon that means it isn't performing a graceful shutdown. Refer: helidon-io/helidon#10156 The 200ms default shutdown delay is a workaround, will change this to default 0 when a Helidon fix is released.
In K8s we need the delay after the actual status has been set to STOPPING. This fixes that.
SentryMan
approved these changes
May 28, 2025
rbygrave
commented
May 28, 2025
| @@ -100,10 +100,10 @@ void stop(WebServer delegate) { | |||
| if (status == STOPPED) { | |||
| log.log(Level.INFO, "already stopped"); | |||
| } else { | |||
| invokeCallbacks(STOPPING); | |||
There was a problem hiding this comment.
This is the fix, need to set STOPPING before performing the shutdown delay.
rbygrave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.