libvirt_version: Add session parameter to is_libvirt_feature_supported

[hholoubk]

Allow is_libvirt_feature_supported() to check the libvirt version on a remote host by accepting an optional session parameter and passing it through to version_compare(). Previously, is_libvirt_feature_supported() always checked the local libvirt version, which could produce incorrect results in migration tests where the destination host version matters.

AI assisted code and commit. Human reviewed.
Signed-off-by: hholoubk hholoubk@redhat.com
Made-with: Cursor

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the is_libvirt_feature_supported function by allowing it to perform libvirt version checks on remote hosts. This capability is crucial for scenarios like migration tests, where the libvirt version on the destination host needs to be accurately assessed, preventing incorrect feature support evaluations that previously relied solely on the local host's version.

Highlights

• Remote Libvirt Version Checking: The is_libvirt_feature_supported function now accepts an optional session parameter, enabling it to check the libvirt version on a remote host rather than always locally.
• Parameter Propagation: The newly introduced session parameter is passed through to the version_compare function, ensuring that remote version comparisons are correctly performed.

Changelog

• virttest/libvirt_version.py
  • Added session parameter to the is_libvirt_feature_supported function signature and updated its docstring.
  • Modified the call to version_compare within is_libvirt_feature_supported to include the new session parameter.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an optional session parameter to the is_libvirt_feature_supported function, allowing it to check the libvirt version on a remote host. The change correctly passes this new parameter to the version_compare function. The implementation is sound and includes appropriate updates to the function's signature and docstring.

[hholoubk]

Hi @smitterl , @dzhengfy, could you please review this small change? It would me help with tp-libvirt test.

Thank you.